voidarc/omnisearch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: free existing allocations in extract_wiki_info to prevent memory leaks

Browse Source
This commit is contained in:
frosty
2026-03-15 15:18:07 -04:00
parent 27899706fb
commit b092bae97b
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Infobox/Wikipedia.c
View File

@@ -46,6 +46,9 @@ static void extract_wiki_info(xmlNode *node, InfoBox *info) {
if (strcmp((const char *)cur_node->name, "page") == 0) { if (strcmp((const char *)cur_node->name, "page") == 0) {
xmlChar *title = xmlGetProp(cur_node, (const xmlChar *)"title"); xmlChar *title = xmlGetProp(cur_node, (const xmlChar *)"title");
if (title) { if (title) {
if (info->title) {
free(info->title);
}
info->title = strdup((const char *)title); info->title = strdup((const char *)title);
const char *base_article_url = "https://en.wikipedia.org/wiki/"; const char *base_article_url = "https://en.wikipedia.org/wiki/";
@@ -55,6 +58,9 @@ static void extract_wiki_info(xmlNode *node, InfoBox *info) {
formatted_title[i] = '_'; formatted_title[i] = '_';
} }
if (info->url) {
free(info->url);
}
info->url = info->url =
malloc(strlen(base_article_url) + strlen(formatted_title) + 1); malloc(strlen(base_article_url) + strlen(formatted_title) + 1);
if (info->url) { if (info->url) {
@@ -69,6 +75,9 @@ static void extract_wiki_info(xmlNode *node, InfoBox *info) {
if (strcmp((const char *)cur_node->name, "thumbnail") == 0) { if (strcmp((const char *)cur_node->name, "thumbnail") == 0) {
xmlChar *source = xmlGetProp(cur_node, (const xmlChar *)"source"); xmlChar *source = xmlGetProp(cur_node, (const xmlChar *)"source");
if (source) { if (source) {
if (info->thumbnail_url) {
free(info->thumbnail_url);
}
info->thumbnail_url = strdup((const char *)source); info->thumbnail_url = strdup((const char *)source);
xmlFree(source); xmlFree(source);
} }
@@ -77,6 +86,9 @@ static void extract_wiki_info(xmlNode *node, InfoBox *info) {
if (strcmp((const char *)cur_node->name, "extract") == 0) { if (strcmp((const char *)cur_node->name, "extract") == 0) {
xmlChar *content = xmlNodeGetContent(cur_node); xmlChar *content = xmlNodeGetContent(cur_node);
if (content) { if (content) {
if (info->extract) {
free(info->extract);
}
info->extract = strdup((const char *)content); info->extract = strdup((const char *)content);
shorten_summary(&(info->extract), 300); shorten_summary(&(info->extract), 300);